Replace <font> in user docs with <span style>#696
Merged
Conversation
yamgent
previously approved these changes
Feb 17, 2019
yamgent
approved these changes
Mar 10, 2019
yamgent
left a comment
yamgent
left a comment
Member
There was a problem hiding this comment.
Seems like this PR was forgotten, sorry about that!
Propose a merge commit message. This one should be relatively simple to write (talk about font becoming obsolete with citation to the Mozilla standard, then mention replacing font with span+style equivalent substitute).
Contributor
Author
|
Proposed commit message: |
Member
|
Nice 👍. |
yamgent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
As suggested in #680 (review).
What is the rationale for this request?
The
<font>HTML tag is deprecated and should not be used in our documentation.What changes did you make? (Give an overview)
I replaced uses of
<font color="[colour]">in our documentation with<span style="color: [colour]">.Is there anything you'd like reviewers to focus on?
Note that the SVG files for FA icons use a
<font>tag as well. While the SVG<font>tag is also deprecated, we probably shouldn't arbitrarily modify upstream assets unless necessary.